Optimization- blocking for- loop over a collection stored in a field Gigantic switch‑case w/ strings Binary serialization Virtual methods that should have been interfaces Unrelated code realName, realName2, fakeActive Custom localization problems A method with 10+ parameters isAgent, isItem, isFire, isBullet, isObjectReal fields X and Y instead of Vector2 sprite, spriteH, spriteWB, spriteWBH Switch statement on direction string Inefficient vector math Dozens of incredibly specific fields tk2d Vehicle is a subclass of Agent ——— OR ——— Agents ARE vehicles 24 directions are strings Start(), Start2(), Start3(), StartReal(), StartReal2() Random- Selection is still ridiculous Locked doors are still one- directional Loop- switch sequence Expensive string concatenation in a loop Data clumps Status effects are still traits Relationships still use both strings and enums Banana and Voucher workaround is still there Enormous if-chain Improper list population w/ excessive copying Undisclosed exceptions Optimization- blocking for- loop over a collection stored in a field Gigantic switch‑case w/ strings Binary serialization Virtual methods that should have been interfaces Unrelated code realName, realName2, fakeActive Custom localization problems A method with 10+ parameters isAgent, isItem, isFire, isBullet, isObjectReal fields X and Y instead of Vector2 sprite, spriteH, spriteWB, spriteWBH Switch statement on direction string Inefficient vector math Dozens of incredibly specific fields tk2d Vehicle is a subclass of Agent ——— OR ——— Agents ARE vehicles 24 directions are strings Start(), Start2(), Start3(), StartReal(), StartReal2() Random- Selection is still ridiculous Locked doors are still one- directional Loop- switch sequence Expensive string concatenation in a loop Data clumps Status effects are still traits Relationships still use both strings and enums Banana and Voucher workaround is still there Enormous if-chain Improper list population w/ excessive copying Undisclosed exceptions
(Print)
Optimization-blocking for-loop over a collection stored in a field
Gigantic switch‑case w/ strings
Binary serialization
Virtual methods that should have been interfaces
Unrelated code
realName, realName2, fakeActive
Custom localization problems
A method with 10+ parameters
isAgent, isItem, isFire, isBullet, isObjectReal fields
X and Y instead of Vector2
sprite, spriteH, spriteWB, spriteWBH
Switch statement on direction string
Inefficient vector math
Dozens of incredibly specific fields
tk2d
Vehicle is a subclass of Agent ——— OR ——— Agents ARE vehicles
24 directions are strings
Start(), Start2(), Start3(), StartReal(), StartReal2()
Random-Selection is still ridiculous
Locked doors are still one-directional
Loop-switch sequence
Expensive string concatenation in a loop
Data clumps
Status effects are still traits
Relationships still use both strings and enums
Banana and Voucher workaround is still there
Enormous if-chain
Improper list population w/ excessive copying
Undisclosed exceptions
